arset=UTF-8
Content-Disposition: inline; filename="084ca50972b4be120eba8d22ce585766ae315c36..dc1a8eadd4c063fe6782fa99f9db41c46b85d048.patch"
Last-Modified: Sat, 04 Jan 2025 02:27:56 GMT
Expires: Sat, 04 Jan 2025 06:27:56 GMT

From dc1a8eadd4c063fe6782fa99f9db41c46b85d048 Mon Sep 17 00:00:00 2001
From: Lars Hjemli
Date: Sun, 22 May 2011 12:45:32 +0200
Subject: shared.c: do not modify const memory

Noticed-by: zhongjj <zhongjj@lemote.com>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
---
 shared.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/shared.c b/shared.c
index 7ec2e19..3926b4a 100644
--- a/shared.c
+++ b/shared.c
@@ -100,23 +100,15 @@ void *cgit_free_commitinfo(struct commitinfo *info)
 char *trim_end(const char *str, char c)
 {
 	int len;
-	char *s, *t;
 
 	if (str == NULL)
 		return NULL;
-	t = (char *)str;
-	len = strlen(t);
-	while(len > 0 && t[len - 1] == c)
+	len = strlen(str);
+	while(len > 0 && str[len - 1] == c)
 		len--;
-
 	if (len == 0)
 		return NULL;
-
-	c = t[len];
-	t[len] = '\0';
-	s = xstrdup(t);
-	t[len] = c;
-	return s;
+	return xstrndup(str, len);
 }
 
 char *strlpart(char *txt, int maxlen)
-- 
cgit v1.2.3-54-g00ecf

nge='this.form.submit();'>
<option value='master' selected='selected'>master</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>Web front-end for git that you're looking at right now. Might have had a few additions from upstream.</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit/about/'>about</a><a href='/cgit/'>summary</a><a href='/cgit/refs/?id=e2416259efe8b9bdad9be9597b1a79443dafdb4e'>refs</a><a href='/cgit/log/tests/t0020-validate-cache.sh'>log</a><a class='active' href='/cgit/tree/tests/t0020-validate-cache.sh?id=e2416259efe8b9bdad9be9597b1a79443dafdb4e'>tree</a><a href='/cgit/commit/tests/t0020-validate-cache.sh?id=e2416259efe8b9bdad9be9597b1a79443dafdb4e' rel='nofollow'>commit</a><a href='/cgit/diff/tests/t0020-validate-cache.sh?id=e2416259efe8b9bdad9be9597b1a79443dafdb4e'>diff</a><a href='/cgit/stats/tests/t0020-validate-cache.sh'>stats</a><a href='https://git.zx2c4.com/cgit/about'>homepage</a></td><td class='form'><form class='right' method='get' action='/cgit/log/tests/t0020-validate-cache.sh'>
<input type='hidden' name='id' value='e2416259efe8b9bdad9be9597b1a79443dafdb4e'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit/tree/?id=e2416259efe8b9bdad9be9597b1a79443dafdb4e'>root</a>/<a href='/cgit/tree/tests?id=e2416259efe8b9bdad9be9597b1a79443dafdb4e'>tests</a>/<a href='/cgit/tree/tests/t0020-validate-cache.sh?id=e2416259efe8b9bdad9be9597b1a79443dafdb4e'>t0020-validate-cache.sh</a></div><div class='content'>blob: 657765d897b5da5dc7f13231c8e0fd2467086a05 (<a href='/cgit/plain/tests/t0020-validate-cache.sh?id=e2416259efe8b9bdad9be9597b1a79443dafdb4e'>plain</a>)
<table summary='blob content' class='blob'>
<tr><td class='linenumbers'><pre><a id='n1' href='#n1'>1</a>
<a id='n2' href='#n2'>2</a>
<a id='n3' href='#n3'>3</a>
<a id='n4' href='#n4'>4</a>
<a id='n5' href='#n5'>5</a>
<a id='n6' href='#n6'>6</a>
<a id='n7' href='#n7'>7</a>
<a id='n8' href='#n8'>8</a>
<a id='n9' href='#n9'>9</a>
<a id='n10' href='#n10'>10</a>
<a id='n11' href='#n11'>11</a>
<a id='n12' href='#n12'>12</a>
<a id='n13' href='#n13'>13</a>
<a id='n14' href='#n14'>14</a>
<a id='n15' href='#n15'>15</a>
<a id='n16' href='#n16'>16</a>
<a id='n17' href='#n17'>17</a>
<a id='n18' href='#n18'>18</a>
<a id='n19' href='#n19'>19</a>
<a id='n20' href='#n20'>20</a>
<a id='n21' href='#n21'>21</a>
<a id='n22' href='#n22'>22</a>
<a id='n23' href='#n23'>23</a>
<a id='n24' href='#n24'>24</a>
<a id='n25' href='#n25'>25</a>
<a id='n26' href='#n26'>26</a>
<a id='n27' href='#n27'>27</a>
<a id='n28' href='#n28'>28</a>
<a id='n29' href='#n29'>29</a>
<a id='n30' href='#n30'>30</a>
<a id='n31' href='#n31'>31</a>
<a id='n32' href='#n32'>32</a>
<a id='n33' href='#n33'>33</a>
<a id='n34' href='#n34'>34</a>
<a id='n35' href='#n35'>35</a>
<a id='n36' href='#n36'>36</a>
<a id='n37' href='#n37'>37</a>
<a id='n38' href='#n38'>38</a>
<a id='n39' href='#n39'>39</a>
<a id='n40' href='#n40'>40</a>
<a id='n41' href='#n41'>41</a>
<a id='n42' href='#n42'>42</a>
<a id='n43' href='#n43'>43</a>
<a id='n44' href='#n44'>44</a>
<a id='n45' href='#n45'>45</a>
<a id='n46' href='#n46'>46</a>
<a id='n47' href='#n47'>47</a>
<a id='n48' href='#n48'>48</a>
<a id='n49' href='#n49'>49</a>
<a id='n50' href='#n50'>50</a>
<a id='n51' href='#n51'>51</a>
<a id='n52' href='#n52'>52</a>
<a id='n53' href='#n53'>53</a>
<a id='n54' href='#n54'>54</a>
<a id='n55' href='#n55'>55</a>
<a id='n56' href='#n56'>56</a>
<a id='n57' href='#n57'>57</a>
<a id='n58' href='#n58'>58</a>
<a id='n59' href='#n59'>59</a>
<a id='n60' href='#n60'>60</a>
<a id='n61' href='#n61'>61</a>
<a id='n62' href='#n62'>62</a>
<a id='n63' href='#n63'>63</a>
<a id='n64' href='#n64'>64</a>
<a id='n65' href='#n65'>65</a>
<a id='n66' href='#n66'>66</a>
<a id='n67' href='#n67'>67</a>
<a id='n68' href='#n68'>68</a>
<a id='n69' href='#n69'>69</a>
<a id='n70' href='#n70'>70</a>
<a id='n71' href='#n71'>71</a>
<a id='n72' href='#n72'>72</a>
<a id='n73' href='#n73'>73</a>
<a id='n74' href='#n74'>74</a>
<a id='n75' href='#n75'>75</a>
<a id='n76' href='#n76'>76</a>
<a id='n77' href='#n77'>77</a>
<a id='n78' href='#n78'>78</a>
</pre></td>
<td class='lines'><pre><code><style>pre { line-height: 125%; }
td.linenos .normal { color: inherit; background-color: transparent; padding-left: 5px; padding-right: 5px; }
span.linenos { color: inherit; background-color: transparent; padding-left: 5px; padding-right: 5px; }
td.linenos .special { color: #000000; background-color: #ffffc0; padding-left: 5px; padding-right: 5px; }
span.linenos.special { color: #000000; background-color: #ffffc0; padding-left: 5px; padding-right: 5px; }
.highlight .hll { background-color: #ffffcc }
.highlight .c { color: #888888 } /* Comment */
.highlight .err { color: #a61717; background-color: #e3d2d2 } /* Error */
.highlight .k { color: #008800; font-weight: bold } /* Keyword */
.highlight .ch { color: #888888 } /* Comment.Hashbang */
.highlight .cm { color: #888888 } /* Comment.Multiline */
.highlight .cp { color: #cc0000; font-weight: bold } /* Comment.Preproc */
.highlight .cpf { color: #888888 } /* Comment.PreprocFile */
.highlight .c1 { color: #888888 } /* Comment.Single */
.highlight .cs { color: #cc0000; font-weight: bold; background-color: #fff0f0 } /* Comment.Special */
.highlight .gd { color: #000000; background-color: #ffdddd } /* Generic.Deleted */
.highlight .ge { font-style: italic } /* Generic.Emph */
.highlight .gr { color: #aa0000 } /* Generic.Error */
.highlight .gh { color: #333333 } /* Generic.Heading */
.highlight .gi { color: #000000; background-color: #ddffdd } /* Generic.Inserted */
.highlight .go { color: #888888 } /* Generic.Output */
.highlight .gp { color: #555555 } /* Generic.Prompt */
.highlight .gs { font-weight: bold } /* Generic.Strong */
.highlight .gu { color: #666666 } /* Generic.Subheading */
.highlight .gt { color: #aa0000 } /* Generic.Traceback */
.highlight .kc { color: #008800; font-weight: bold } /* Keyword.Constant */
.highlight .kd { color: #008800; font-weight: bold } /* Keyword.Declaration */
.highlight .kn { color: #008800; font-weight: bold } /* Keyword.Namespace */
.highlight .kp { color: #008800 } /* Keyword.Pseudo */
.highlight .kr { color: #008800; font-weight: bold } /* Keyword.Reserved */
.highlight .kt { color: #888888; font-weight: bold } /* Keyword.Type */
.highlight .m { color: #0000DD; font-weight: bold } /* Literal.Number */
.highlight .s { color: #dd2200; background-color: #fff0f0 } /* Literal.String */
.highlight .na { color: #336699 } /* Name.Attribute */
.highlight .nb { color: #003388 } /* Name.Builtin */
.highlight .nc { color: #bb0066; font-weight: bold } /* Name.Class */
.highlight .no { color: #003366; font-weight: bold } /* Name.Constant */
.highlight .nd { color: #555555 } /* Name.Decorator */
.highlight .ne { color: #bb0066; font-weight: bold } /* Name.Exception */
.highlight .nf { color: #0066bb; font-weight: bold } /* Name.Function */
.highlight .nl { color: #336699; font-style: italic } /* Name.Label */
.highlight .nn { color: #bb0066; font-weight: bold } /* Name.Namespace */
.highlight .py { color: #336699; font-weight: bold } /* Name.Property */
.highlight .nt { color: #bb0066; font-weight: bold } /* Name.Tag */
.highlight .nv { color: #336699 } /* Name.Variable */
.highlight .ow { color: #008800 } /* Operator.Word */
.highlight .w { color: #bbbbbb } /* Text.Whitespace */
.highlight .mb { color: #0000DD; font-weight: bold } /* Literal.Number.Bin */
.highlight .mf { color: #0000DD; font-weight: bold } /* Literal.Number.Float */
.highlight .mh { color: #0000DD; font-weight: bold } /* Literal.Number.Hex */
.highlight .mi { color: #0000DD; font-weight: bold } /* Literal.Number.Integer */
.highlight .mo { color: #0000DD; font-weight: bold } /* Literal.Number.Oct */
.highlight .sa { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Affix */
.highlight .sb { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Backtick */
.highlight .sc { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Char */
.highlight .dl { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Delimiter */
.highlight .sd { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Doc */
.highlight .s2 { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Double */
.highlight .se { color: #0044dd; background-color: #fff0f0 } /* Literal.String.Escape */
.highlight .sh { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Heredoc */
.highlight .si { color: #3333bb; background-color: #fff0f0 } /* Literal.String.Interpol */
.highlight .sx { color: #22bb22; background-color: #f0fff0 } /* Literal.String.Other */
.highlight .sr { color: #008800; background-color: #fff0ff } /* Literal.String.Regex */
.highlight .s1 { color: #dd2200; background-color: #fff0f0 } /* Literal.String.Single */
.highlight .ss { color: #aa6600; background-color: #fff0f0 } /* Literal.String.Symbol */
.highlight .bp { color: #003388 } /* Name.Builtin.Pseudo */
.highlight .fm { color: #0066bb; font-weight: bold } /* Name.Function.Magic */
.highlight .vc { color: #336699 } /* Name.Variable.Class */
.highlight .vg { color: #dd7700 } /* Name.Variable.Global */
.highlight .vi { color: #3333bb } /* Name.Variable.Instance */
.highlight .vm { color: #336699 } /* Name.Variable.Magic */
.highlight .il { color: #0000DD; font-weight: bold } /* Literal.Number.Integer.Long */</style><div class="highlight"><pre><span></span><span class="ch">#!/bin/sh</span>

<span class="nv">test_description</span><span class="o">=</span><span class="s1">&#39;Validate cache&#39;</span>
.<span class="w"> </span>./setup.sh

test_expect_success<span class="w"> </span><span class="s1">&#39;verify cache-size=0&#39;</span><span class="w"> </span><span class="s1">&#39;</span>

<span class="s1">	rm -f cache/* &amp;&amp;</span>
<span class="s1">	sed -e &quot;s/cache-size=1021$/cache-size=0/&quot; cgitrc &gt;cgitrc.tmp &amp;&amp;</span>
<span class="s1">	mv -f cgitrc.tmp cgitrc &amp;&amp;</span>
<span class="s1">	cgit_url &quot;&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/refs&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/tree&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/log&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/diff&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/patch&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/refs&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/tree&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/log&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/diff&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/patch&quot; &amp;&amp;</span>
<span class="s1">	ls cache &gt;output &amp;&amp;</span>
<span class="s1">	test_line_count = 0 output</span>
<span class="s1">&#39;</span>

test_expect_success<span class="w"> </span><span class="s1">&#39;verify cache-size=1&#39;</span><span class="w"> </span><span class="s1">&#39;</span>

<span class="s1">	rm -f cache/* &amp;&amp;</span>
<span class="s1">	sed -e &quot;s/cache-size=0$/cache-size=1/&quot; cgitrc &gt;cgitrc.tmp &amp;&amp;</span>
<span class="s1">	mv -f cgitrc.tmp cgitrc &amp;&amp;</span>
<span class="s1">	cgit_url &quot;&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/refs&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/tree&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/log&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/diff&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/patch&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/refs&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/tree&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/log&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/diff&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/patch&quot; &amp;&amp;</span>
<span class="s1">	ls cache &gt;output &amp;&amp;</span>
<span class="s1">	test_line_count = 1 output</span>
<span class="s1">&#39;</span>

test_expect_success<span class="w"> </span><span class="s1">&#39;verify cache-size=1021&#39;</span><span class="w"> </span><span class="s1">&#39;</span>

<span class="s1">	rm -f cache/* &amp;&amp;</span>
<span class="s1">	sed -e &quot;s/cache-size=1$/cache-size=1021/&quot; cgitrc &gt;cgitrc.tmp &amp;&amp;</span>
<span class="s1">	mv -f cgitrc.tmp cgitrc &amp;&amp;</span>
<span class="s1">	cgit_url &quot;&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/refs&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/tree&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/log&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/diff&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/patch&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/refs&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/tree&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/log&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/diff&quot; &amp;&amp;</span>
<span class="s1">	cgit_url &quot;bar/patch&quot; &amp;&amp;</span>
<span class="s1">	ls cache &gt;output &amp;&amp;</span>
<span class="s1">	test_line_count = 13 output &amp;&amp;</span>
<span class="s1">	cgit_url &quot;foo/ls_cache&quot; &gt;output.full &amp;&amp;</span>
<span class="s1">	strip_headers &lt;output.full &gt;output &amp;&amp;</span>
<span class="s1">	test_line_count = 13 output &amp;&amp;</span>
<span class="s1">	# Check that ls_cache output is cached correctly</span>
<span class="s1">	cgit_url &quot;foo/ls_cache&quot; &gt;output.second &amp;&amp;</span>
<span class="s1">	test_cmp output.full output.second</span>
<span class="s1">&#39;</span>

test_done
</pre></div>
</code></pre></td></tr></table>
</div> <!-- class=content -->
<div class='footer'>generated by <a href='https://git.zx2c4.com/cgit/about/'>cgit v1.2.3-54-g00ecf</a> (<a href='https://git-scm.com/'>git 2.39.0</a>) at 2025-01-04 02:27:58 +0000</div>
</div> <!-- id=cgit -->
</body>
</html>
