summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorJohn Keeping2017-01-15 12:29:38 +0000
committerJason A. Donenfeld2017-08-10 15:58:24 +0200
commit6d3c8bc37f6124c2193d66587079975d381aa435 (patch)
treeef6b49f3a8882a95a5e1f3fc64b41459b6dac4e7
parent86a6d358f7a6c2432fde86b9e3c5011a656f20e4 (diff)
downloadcgit-6d3c8bc37f6124c2193d66587079975d381aa435.tar
cgit-6d3c8bc37f6124c2193d66587079975d381aa435.tar.gz
cgit-6d3c8bc37f6124c2193d66587079975d381aa435.zip
ui-atom: properly escape delimiter in page link
If the delimiter here is '&' then it needs to be escaped for inclusion in an attribute. Use html_attrf() to ensure that this happens (we know that hex won't need escaping, but this makes it clearer what's happening. Signed-off-by: John Keeping <john@keeping.me.uk>
-rw-r--r--ui-atom.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ui-atom.c b/ui-atom.c
index 41838d3..3866823 100644
--- a/ui-atom.c
+++ b/ui-atom.c
@@ -63,7 +63,7 @@ static void add_entry(struct commit *commit, const char *host)
html_attr(pageurl);
if (ctx.cfg.virtual_root)
delim = '?';
- htmlf("%cid=%s", delim, hex);
+ html_attrf("%cid=%s", delim, hex);
html("'/>\n");
free(pageurl);
}
f='#n143'>143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221